zstan commented on code in PR #4683: URL: https://github.com/apache/ignite-3/pull/4683#discussion_r1832503679
########## modules/sql-engine/src/integrationTest/sql/types/timestamp/test_timestamp_ms.test: ########## @@ -1,7 +1,6 @@ # name: test/sql/types/timestamp/test_timestamp_ms.test # description: Test milliseconds with timestamp # group: [timestamp] -# Ignore https://issues.apache.org/jira/browse/IGNITE-19804 Review Comment: plz move this "Ignore" into correct place, where such problem already present. here : test_approximate_distinct_count.test_ignore ########## modules/sql-engine/src/integrationTest/sql/types/timestamp/test_timestamp.test: ########## @@ -9,56 +9,94 @@ statement ok CREATE TABLE IF NOT EXISTS timestamp_t (t TIMESTAMP); statement ok -INSERT INTO timestamp_t VALUES (timestamp '2008-01-01 00:00:01'), (timestamp '2007-01-01 00:00:01'), (timestamp '2008-02-01 00:00:01'), (timestamp '2008-01-02 00:00:01'), (timestamp '2008-01-01 10:00:00'), (timestamp '2008-01-01 00:10:00'), (timestamp '2008-01-01 00:00:10') +INSERT INTO timestamp_t VALUES (timestamp '2008-01-01 00:00:01'), (NULL), (timestamp '2007-01-01 00:00:01'), (timestamp '2008-02-01 00:00:01'), (timestamp '2008-01-02 00:00:01'), (timestamp '2008-01-01 10:00:00'), (timestamp '2008-01-01 00:10:00'), (timestamp '2008-01-01 00:00:10') query T SELECT timestamp '2017-07-23 13:10:11'; ---- -2017-07-23T13:10:11 +2017-07-23 13:10:11 + +# iso timestamps +skipif ignite3 +# https://issues.apache.org/jira/browse/IGNITE-19161 +query TT +SELECT timestamp '2017-07-23T13:10:11', timestamp '2017-07-23T13:10:11Z'; +---- +2017-07-23 13:10:11 +2017-07-23 13:10:11 + +# spaces everywhere +skipif ignite3 +# https://issues.apache.org/jira/browse/IGNITE-19161 +query T +SELECT timestamp ' 2017-07-23 13:10:11 '; +---- +2017-07-23 13:10:11 # other trailing, preceding, or middle gunk is not accepted -statement error +statement error: Illegal TIMESTAMP literal SELECT timestamp ' 2017-07-23 13:10:11 AA'; -statement error +statement error: Illegal TIMESTAMP literal SELECT timestamp 'AA2017-07-23 13:10:11'; -statement error +statement error: Illegal TIMESTAMP literal SELECT timestamp '2017-07-23A13:10:11'; query T -SELECT t FROM timestamp_t ORDER BY t LIMIT 1; +SELECT t FROM timestamp_t ORDER BY t; ---- -2007-01-01T00:00:01 +2007-01-01 00:00:01 +2008-01-01 00:00:01 +2008-01-01 00:00:10 +2008-01-01 00:10:00 +2008-01-01 10:00:00 +2008-01-02 00:00:01 +2008-02-01 00:00:01 +NULL query T SELECT MIN(t) FROM timestamp_t; ---- -2007-01-01T00:00:01 +2007-01-01 00:00:01 query T SELECT MAX(t) FROM timestamp_t; ---- -2008-02-01T00:00:01 +2008-02-01 00:00:01 -statement error +statement error: Cannot apply 'SUM' to arguments of type 'SUM(<TIMESTAMP(6)>)'. Supported form(s): 'SUM(<NUMERIC>)' SELECT SUM(t) FROM timestamp_t -statement error +statement error: Cannot apply 'AVG' to arguments of type 'AVG(<TIMESTAMP(6)>)'. Supported form(s): 'AVG(<NUMERIC>)' SELECT AVG(t) FROM timestamp_t -statement error +statement error: Cannot apply '+' to arguments of type '<TIMESTAMP(6)> + <TIMESTAMP(6)>'. Supported form(s): '<NUMERIC> + <NUMERIC>' SELECT t+t FROM timestamp_t -statement error +statement error: Cannot apply '*' to arguments of type '<TIMESTAMP(6)> * <TIMESTAMP(6)>'. Supported form(s): '<NUMERIC> * <NUMERIC>' SELECT t*t FROM timestamp_t -statement error +statement error: Cannot apply '/' to arguments of type '<TIMESTAMP(6)> / <TIMESTAMP(6)>'. Supported form(s): '<NUMERIC> / <NUMERIC>' SELECT t/t FROM timestamp_t -statement error +statement error: Cannot apply '%' to arguments of type '<TIMESTAMP(6)> % <TIMESTAMP(6)>'. Supported form(s): '<EXACT_NUMERIC> % <EXACT_NUMERIC>' SELECT t%t FROM timestamp_t +skipif ignite3 +# Ihttps://issues.apache.org/jira/browse/IGNITE-20968 Review Comment: ```suggestion # https://issues.apache.org/jira/browse/IGNITE-20968 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
