korlov42 commented on code in PR #4629: URL: https://github.com/apache/ignite-3/pull/4629#discussion_r1822799914
########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/ExecutionDistributionProvider.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine; + +import java.util.Collection; +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.hlc.HybridTimestamp; +import org.apache.ignite.internal.sql.engine.ExecutionDistributionProviderImpl.DistributionHolder; +import org.apache.ignite.internal.sql.engine.schema.IgniteTable; + +/** Execution nodes information provider. */ +@FunctionalInterface +public interface ExecutionDistributionProvider { Review Comment: I would prefer to keep new interface similar to old one (`ExecutionTargetProvider`): distribution per single table/system view. That way it will be easier to provide custom implementations in tests ########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/MappingContext.java: ########## @@ -32,7 +32,7 @@ class MappingContext { private final ExecutionTargetFactory targetFactory; - private RelOptCluster cluster; + static final RelOptCluster CLUSTER = Commons.cluster(); Review Comment: I feel like this is not a good idea. I remember cluster is storing some meta internally (?), therefore having shared static cluster may cause memory leaks ########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/ExecutionDistributionProvider.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine; + +import java.util.Collection; +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.hlc.HybridTimestamp; +import org.apache.ignite.internal.sql.engine.ExecutionDistributionProviderImpl.DistributionHolder; Review Comment: it's strange that interface which is supposed to be an abstraction depends on internal class of particular implementation of this very interface -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
