alievmirza commented on code in PR #4594:
URL: https://github.com/apache/ignite-3/pull/4594#discussion_r1819325322
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -677,19 +679,24 @@ private void restoreGlobalStateFromLocalMetastorage(long
recoveryRevision) {
// that one value is not null, but other is null.
assert nodeAttributesEntry.value() != null;
- logicalTopology = fromBytes(lastHandledTopologyEntry.value());
+ logicalTopology =
deserializeLogicalTopologySet(lastHandledTopologyEntry.value());
- nodesAttributes = fromBytes(nodeAttributesEntry.value());
+ nodesAttributes =
deserializeNodesAttributes(nodeAttributesEntry.value());
}
- assert lastHandledTopologyEntry.value() == null ||
logicalTopology.equals(fromBytes(lastHandledTopologyEntry.value()))
+ assert lastHandledTopologyEntry.value() == null
+ ||
logicalTopology.equals(deserializeLogicalTopologySet(lastHandledTopologyEntry.value()))
: "Initial value of logical topology was changed after
initialization from the Meta Storage manager.";
assert nodeAttributesEntry.value() == null
- ||
nodesAttributes.equals(fromBytes(nodeAttributesEntry.value()))
+ ||
nodesAttributes.equals(deserializeNodesAttributes(nodeAttributesEntry.value()))
: "Initial value of nodes' attributes was changed after
initialization from the Meta Storage manager.";
}
+ private static Map<UUID, NodeWithAttributes>
deserializeNodesAttributes(byte[] bytes) {
Review Comment:
lets place it in `DistributionZonesUtil` as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
