tkalkirill commented on code in PR #4637:
URL: https://github.com/apache/ignite-3/pull/4637#discussion_r1818477369


##########
modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItIdempotentCommandCacheTest.java:
##########
@@ -475,46 +467,6 @@ public void 
testIdempotentCacheRestoreFromSnapshot(IdempotentCommand idempotentC
         }
     }
 
-    @Test
-    void testEvictIdempotentCommandsCacheAfterCompaction() {

Review Comment:
   The test checks that if there is a race between compaction and eviction from 
command cache, then we would make a fallback on the full scan 
(KeyValueStorage#range without upper bound) when reading. But since we don't do 
this anymore, the test is not needed in my opinion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to