alex-plekhanov commented on code in PR #11616:
URL: https://github.com/apache/ignite/pull/11616#discussion_r1816496263
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedConfigurationProcessor.java:
##########
@@ -160,15 +216,12 @@ private static String toPropertyKey(String
metaStorageKey) {
* @return Public properties.
*/
public List<DistributedChangeableProperty<Serializable>> properties() {
- return props.values().stream()
- .filter(p -> p instanceof DistributedChangeableProperty)
- .map(p -> (DistributedChangeableProperty<Serializable>)p)
- .collect(Collectors.toList());
+ return U.sealList(props.values());
Review Comment:
Currently, it's used only by control.sh to show list of properties, so
overhead is very small. Also, `sealList` and `Collections.unmodifiable*`
methods are used for internal code too, you can search for references of this
method to ensure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
