vldpyatkov commented on code in PR #4590:
URL: https://github.com/apache/ignite-3/pull/4590#discussion_r1815403350
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaService.java:
##########
@@ -55,8 +55,8 @@
/** The service is intended to execute requests on replicas. */
public class ReplicaService {
- /** Retry timeout. */
- private static final int RETRY_TIMEOUT_MILLIS = 10;
+ /** Default timeout for retrying replica operation. */
+ public static final int DEFAULT_REPLICA_OPERATION_RETRY_INTERVAL = 10;
Review Comment:
Move this to ReplicationConfigurationSchema and do not use a constant in the
*Schema class.
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java:
##########
@@ -737,6 +737,13 @@ public int pending() {
@Override
public CompletableFuture<Void> startAsync(ComponentContext
componentContext) {
return inBusyLockAsync(busyLock, () -> {
+ var deadlockPreventionPolicy = new DeadlockPreventionPolicyImpl(
+
txConfig.deadlockPreventionPolicy().txIdComparator().value(),
+ txConfig.deadlockPreventionPolicy().waitTimeout().value()
+ );
+
+ lockManager.start(deadlockPreventionPolicy);
Review Comment:
Why does Transaction manager start Lock manager?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
