tkalkirill commented on code in PR #4610:
URL: https://github.com/apache/ignite-3/pull/4610#discussion_r1814777721
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/raft/MetaStorageWriteHandler.java:
##########
@@ -227,6 +228,17 @@ private void
handleWriteWithTime(CommandClosure<WriteCommand> clo, MetaStorageWr
evictIdempotentCommandsCache(cmd.evictionTimestamp(), context);
clo.result(null);
+ } else if (command instanceof CompactionCommand) {
+ CompactionCommand cmd = (CompactionCommand) command;
+
+ long compactionRevision = cmd.compactionRevision();
+
+ storage.saveCompactionRevision(compactionRevision, context);
+ storage.startCompaction(compactionRevision);
Review Comment:
Yes, because after deploying the watches we will need to run a background
compaction for the latest compaction revision and we will not have the
`KeyValueUpdateContext` on hand.
On the other hand, we can add a `startCompactionAfterRecovery` that will do
the same thing but without `saveCompactionRevision` and add it
`startCompaction`, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
