nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1812477464
########## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/lob/JdbcBlobBufferPointer.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.jdbc2.lob; + +/** + * Keeps a pointer to some position in a {@link JdbcBlobBuffer}. + */ +class JdbcBlobBufferPointer { + /** Current buffer position. */ + private long pos; Review Comment: Let's do the following: 1. Make idx, inBufPos int - default contstructor will set it to 0 which seems correct, because pos equal to 0, also. 2. Remove setPos and use: ``` /** {@inheritDoc} */ @Override public void advance(JdbcBlobBufferPointer pos, long step) { long newPos = pos.getPos() + step; pos.setPos(newPos, 0, newPos); } ``` for readonly implementation. This will allow to have consistent logic in both implementation and get rid of `Integer` and `recover` calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
