ivandasch commented on code in PR #11613:
URL: https://github.com/apache/ignite/pull/11613#discussion_r1812106931
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/cache/ClientCacheFieldsQueryCursor.java:
##########
@@ -44,9 +44,13 @@ class ClientCacheFieldsQueryCursor extends
ClientCacheQueryCursor<List> {
/** {@inheritDoc} */
@Override void writeEntry(BinaryRawWriterEx writer, List e) {
- assert e.size() == columnCount;
+ //assert e.size() == columnCount : "Wrong column count : " + e.size()
+ " != " + columnCount;
+ assert e.size() >= columnCount : "Column count less then requrested: "
+ e.size() + " < " + columnCount;
- for (Object o : e)
- writer.writeObjectDetached(o);
+ // H2 engine can add extra columns in the end of result set.
Review Comment:
"at the end of" is beter
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/cache/ClientCacheFieldsQueryCursor.java:
##########
@@ -44,9 +44,13 @@ class ClientCacheFieldsQueryCursor extends
ClientCacheQueryCursor<List> {
/** {@inheritDoc} */
@Override void writeEntry(BinaryRawWriterEx writer, List e) {
- assert e.size() == columnCount;
+ //assert e.size() == columnCount : "Wrong column count : " + e.size()
+ " != " + columnCount;
+ assert e.size() >= columnCount : "Column count less then requrested: "
+ e.size() + " < " + columnCount;
- for (Object o : e)
- writer.writeObjectDetached(o);
+ // H2 engine can add extra columns in the end of result set.
Review Comment:
"at the end of" is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
