ascherbakoff commented on code in PR #4540:
URL: https://github.com/apache/ignite-3/pull/4540#discussion_r1810845690
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -3335,7 +3323,7 @@ private CompletableFuture<IgniteBiTuple<RowId,
Collection<Lock>>> takeLocksForUp
* @return Future completes with tuple {@link RowId} and collection of
{@link Lock}.
*/
private CompletableFuture<IgniteBiTuple<RowId, Collection<Lock>>>
takeLocksForInsert(BinaryRow binaryRow, RowId rowId, UUID txId) {
- return lockManager.acquire(txId, new LockKey(tableId()), LockMode.IX)
// IX lock on table
+ return lockManager.acquire(txId, new LockKey(replicationGroupId),
LockMode.IX)
Review Comment:
Good point, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
