ibessonov commented on code in PR #4609: URL: https://github.com/apache/ignite-3/pull/4609#discussion_r1810071506
########## modules/configuration-api/src/main/java/org/apache/ignite/configuration/validation/CamelCaseKeys.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.configuration.validation; + +import static java.lang.annotation.ElementType.FIELD; +import static java.lang.annotation.RetentionPolicy.RUNTIME; + +import java.lang.annotation.Retention; +import java.lang.annotation.Target; +import org.apache.ignite.configuration.annotation.NamedConfigValue; + +/** + * Signifies that a {@link NamedConfigValue} can't have elements with keys not in Review Comment: Just a question - why do you use a double negation instead of a direct description, something like _"signifies that a named config value only has elements with keys in lower camel case"_? It is confusing to read, and usually we try to avoid such constructions ########## modules/configuration/src/main/java/org/apache/ignite/internal/configuration/validation/CamelCaseKeysValidator.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.configuration.validation; + +import java.util.regex.Pattern; +import org.apache.ignite.configuration.NamedListView; +import org.apache.ignite.configuration.validation.CamelCaseKeys; +import org.apache.ignite.configuration.validation.ValidationContext; +import org.apache.ignite.configuration.validation.ValidationIssue; +import org.apache.ignite.configuration.validation.Validator; + +/** {@link Validator} implementation for the {@link CamelCaseKeys} annotation. */ +public class CamelCaseKeysValidator implements Validator<CamelCaseKeys, NamedListView<?>> { + private static final String CAMEL_CASE_GOOGLE_STYLE = "https://google.github.io/styleguide/javaguide.html#s5.3-camel-case";; Review Comment: Why have you decide to use Google's regex, did you check this pattern yourself? It looks really weird, and it contradicts my intuition. Especially the last part - `([A-Z])?`, why does it exist? `(\\d)|([A-Z0-9]...` is also weird, it means that we allow both "a5b" and "a5B", why would we do it :) Why do we allow digits in the first place? I guess this guide is inappropriate for the task. I recommend re-writing it manually so that it fits our goals, and also remove the reference to Google guidelines. What do you think? ########## modules/configuration/src/main/java/org/apache/ignite/internal/configuration/validation/CamelCaseKeysValidator.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.configuration.validation; + +import java.util.regex.Pattern; +import org.apache.ignite.configuration.NamedListView; +import org.apache.ignite.configuration.validation.CamelCaseKeys; +import org.apache.ignite.configuration.validation.ValidationContext; +import org.apache.ignite.configuration.validation.ValidationIssue; +import org.apache.ignite.configuration.validation.Validator; + +/** {@link Validator} implementation for the {@link CamelCaseKeys} annotation. */ +public class CamelCaseKeysValidator implements Validator<CamelCaseKeys, NamedListView<?>> { + private static final String CAMEL_CASE_GOOGLE_STYLE = "https://google.github.io/styleguide/javaguide.html#s5.3-camel-case";; + + private final Pattern camelCalePattern = Pattern.compile("[a-z]+((\\d)|([A-Z0-9][a-z0-9]+))*([A-Z])?"); Review Comment: "ca**s**e", not "ca**l**e" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
