sanpwc commented on code in PR #4581:
URL: https://github.com/apache/ignite-3/pull/4581#discussion_r1809042343


##########
modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClock.java:
##########
@@ -28,13 +28,29 @@ public interface HybridClock {
      */
     long nowLong();
 
+    /**
+     * Gets a current timestamp as long. It is a fast way to get timestamp 
because it does not have to update internal state.

Review Comment:
   Could you please also fix the javadoc here. 



##########
modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClock.java:
##########
@@ -28,13 +28,29 @@ public interface HybridClock {
      */
     long nowLong();
 
+    /**
+     * Gets a current timestamp as long. It is a fast way to get timestamp 
because it does not have to update internal state.
+     * This timestamp is not unique, and equal to or less than that value is 
returned by {@link this#nowLong()}.
+     *
+     * @return The hybrid timestamp.
+     */
+    long currentLong();
+
     /**
      * Creates a timestamp for new event.
      *
      * @return The hybrid timestamp.
      */
     HybridTimestamp now();
 
+    /**
+     * Gets a current timestamp. It is a fast way to get timestamp because it 
does not have to update internal state.

Review Comment:
   And here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to