valepakh commented on code in PR #4598:
URL: https://github.com/apache/ignite-3/pull/4598#discussion_r1808985125
##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/metric/ItNodeMetricCommandTest.java:
##########
@@ -17,57 +17,94 @@
package org.apache.ignite.internal.cli.commands.metric;
+import static org.apache.ignite.internal.TestWrappers.unwrapIgniteImpl;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertAll;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Stream;
import org.apache.ignite.internal.cli.CliIntegrationTest;
-import org.junit.jupiter.api.DisplayName;
+import org.apache.ignite.rest.client.model.MetricSource;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.function.Executable;
/** Tests for node metric commands. */
class ItNodeMetricCommandTest extends CliIntegrationTest {
private static final String NL = System.lineSeparator();
@Test
- @DisplayName("Should display disabled jvm metric source when valid
node-url is given")
- void nodeMetricList() {
- // When list node metric with valid url
- execute("node", "metric", "source", "list", "--plain", "--url",
NODE_URL);
+ void metricEnable() {
+ // When disable cluster metric with valid url
+ execute("node", "metric", "source", "disable", "jvm", "--url",
NODE_URL);
Review Comment:
This test actually tests node metrics, it disables a metric source on a
single node and checks that only this node has this metric source disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
