Re: [PR] IGNITE-23353 Improve CREATE TABLE syntax [ignite-3]

[via GitHub]

ygerzhedovich commented on code in PR #4599:
URL: https://github.com/apache/ignite-3/pull/4599#discussion_r1808938105


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/benchmark/SqlIndexScanBenchmark.java:
##########
@@ -92,7 +92,7 @@ public void setUp() throws Exception {
             if 
(!Files.exists(workDir().resolve(DATASET_READY_MARK_FILE_NAME))) {
                 sql.executeScript(
                         "CREATE ZONE single_partition_zone WITH replicas = 1, 
partitions = 1;"
-                                + "CREATE TABLE test (id INT PRIMARY KEY, val 
DATE) WITH primary_zone = single_partition_zone;"
+                                + "CREATE TABLE test (id INT PRIMARY KEY, val 
DATE) zone single_partition_zone;"

Review Comment:
   fixed



##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java:
##########
@@ -1758,7 +1757,7 @@ public void tableRecoveryOnMultipleRestartingNodes(int 
nodeThatWrittenAssignment
         nodeInhibitor2.startInhibit();
 
         sql.executeAsync(null, "CREATE TABLE " + tableName
-                + "(id INT PRIMARY KEY, name VARCHAR) WITH PRIMARY_ZONE='" + 
zoneName + "';");
+                + "(id INT PRIMARY KEY, name VARCHAR) ZONE" + zoneName + ";");

Review Comment:
   fixed



##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/schemasync/ItSchemaSyncMultiNodeTest.java:
##########
@@ -186,7 +186,7 @@ void ddlAfterDdlOnAnotherNodeSeesFirstDdlResults() {
             });
 
             CompletableFuture<Void> tableCreationFuture = runAsync(() -> 
cluster.doInSession(NODE_1_INDEX, session -> {
-                executeUpdate("CREATE TABLE " + TABLE_NAME + " (id int PRIMARY 
KEY, val varchar) WITH primary_zone='TEST_ZONE'", session);
+                executeUpdate("CREATE TABLE " + TABLE_NAME + " (id int PRIMARY 
KEY, val varchar) zone TEST_ZONE", session);

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org