sashapolo commented on code in PR #4602: URL: https://github.com/apache/ignite-3/pull/4602#discussion_r1808628050
########## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/AbstractKeyValueStorage.java: ########## @@ -196,6 +223,41 @@ public long getCompactionRevision() { } } + @Override + public void startCompaction(long revision) { Review Comment: The problem here is that this parameter clashes with the `rev` field, which makes it hard to read the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org