nizhikov commented on code in PR #11518:
URL: https://github.com/apache/ignite/pull/11518#discussion_r1808487593
##########
modules/core/src/main/java/org/apache/ignite/internal/binary/streams/BinaryAbstractOutputStream.java:
##########
@@ -29,14 +29,17 @@ public abstract class BinaryAbstractOutputStream extends
BinaryAbstractStream
/** Minimal capacity when it is reasonable to start doubling resize. */
private static final int MIN_CAP = 256;
+ /** Max capacity when it is still reasonable doubling resize. */
+ protected static final int MAX_CAP = 32 * 1024 * 1024;
Review Comment:
This changes looks like overcomplication without clear performance benefits.
Do we really need them?
Can we revert it here and move to the separate PR only if there are clear
real-worls benchmarks that show some advantage of new restriction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
