Phillippko commented on code in PR #4578: URL: https://github.com/apache/ignite-3/pull/4578#discussion_r1806344242
########## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/RaftGroupConfigurationSerializer.java: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.raft; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; +import org.apache.ignite.internal.util.io.IgniteDataInput; +import org.apache.ignite.internal.util.io.IgniteDataOutput; +import org.apache.ignite.internal.versioned.VersionedSerializer; +import org.jetbrains.annotations.Nullable; + +/** + * {@link VersionedSerializer} for {@link RaftGroupConfiguration} instances. + */ +public class RaftGroupConfigurationSerializer extends VersionedSerializer<RaftGroupConfiguration> { + /** Serializer instance. */ + public static final RaftGroupConfigurationSerializer INSTANCE = new RaftGroupConfigurationSerializer(); + + @Override + protected void writeExternalData(RaftGroupConfiguration config, IgniteDataOutput out) throws IOException { + writeStringList(config.peers(), out); + writeStringList(config.learners(), out); + writeNullableStringList(config.oldPeers(), out); + writeNullableStringList(config.oldLearners(), out); + } + + private static void writeStringList(List<String> strings, IgniteDataOutput out) throws IOException { + out.writeVarInt(strings.size()); + for (String str : strings) { + out.writeUTF(str); + } + } + + private static void writeNullableStringList(@Nullable List<String> strings, IgniteDataOutput out) throws IOException { + if (strings == null) { + out.writeVarInt(-1); + } else { + writeStringList(strings, out); + } + } + + @Override + protected RaftGroupConfiguration readExternalData(byte protoVer, IgniteDataInput in) throws IOException { + List<String> peers = readStringList(in); + List<String> learners = readStringList(in); + List<String> oldPeers = readNullableStringList(in); + List<String> oldLearners = readNullableStringList(in); + + return new RaftGroupConfiguration(peers, learners, oldPeers, oldLearners); + } + + private static List<String> readStringList(IgniteDataInput in) throws IOException { Review Comment: Could we move this methods to a parent class? I don't see raft group specific logic in them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
