rpuch commented on code in PR #4562:
URL: https://github.com/apache/ignite-3/pull/4562#discussion_r1802490749
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/topology/api/LogicalNode.java:
##########
@@ -71,28 +71,32 @@ public LogicalNode(UUID id, String name, NetworkAddress
address) {
* @param userAttributes Node attributes defined in configuration.
*/
public LogicalNode(ClusterNode clusterNode, Map<String, String>
userAttributes) {
- this(clusterNode, userAttributes, Collections.emptyMap(),
Collections.emptyList());
+ this(clusterNode, userAttributes, emptyMap(), emptyList());
}
/**
* Constructor.
*
- * @param clusterNode Represents a node in a cluster.
+ * @param node Represents a node in a cluster.
* @param userAttributes Node attributes defined in configuration.
* @param systemAttributes Internal node attributes provided by system
components at startup.
* @param storageProfiles List of storage profiles, which the node
supports.
*/
public LogicalNode(
- ClusterNode clusterNode,
+ ClusterNode node,
Map<String, String> userAttributes,
Map<String, String> systemAttributes,
List<String> storageProfiles
) {
- super(clusterNode.id(), clusterNode.name(), clusterNode.address(),
clusterNode.nodeMetadata());
-
- this.userAttributes = userAttributes == null ? Collections.emptyMap()
: userAttributes;
- this.systemAttributes = systemAttributes == null ?
Collections.emptyMap() : systemAttributes;
- this.storageProfiles = storageProfiles;
+ this(
+ node.id(),
+ node.name(),
+ node.address(),
+ node.nodeMetadata(),
+ userAttributes == null ? emptyMap() : userAttributes,
Review Comment:
I tried to make sure we never pass nulls to parameters of this constructor
(which was the case) and removed the null checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
