xtern commented on code in PR #4554:
URL: https://github.com/apache/ignite-3/pull/4554#discussion_r1802459185
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexNodeFinishedRwTransactionsChecker.java:
##########
@@ -148,17 +151,28 @@ public <T> T inUpdateRwTxCountLock(Supplier<T> supplier) {
}
@Override
- public HybridTimestamp minimumBeginTime() {
+ public long minimumRequiredTime() {
readWriteLock.writeLock().lock();
+ int minRequiredVer;
+
try {
- // TODO https://issues.apache.org/jira/browse/IGNITE-22975 Improve
minimum begin time determination
- return txCatalogVersionByBeginTxTs.keySet().stream()
- .min(HybridTimestamp::compareTo)
- .orElse(clock.now());
+ Entry<Integer, Long> entry = txCountByCatalogVersion.lastEntry();
Review Comment:
:woman_facepalming: Thanks, fixed
> The fact that all tests have passed freaks me out tbh
The problem with the test was that only single RW transaction started on
each node.
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexNodeFinishedRwTransactionsChecker.java:
##########
@@ -148,17 +151,28 @@ public <T> T inUpdateRwTxCountLock(Supplier<T> supplier) {
}
@Override
- public HybridTimestamp minimumBeginTime() {
+ public long minimumRequiredTime() {
readWriteLock.writeLock().lock();
+ int minRequiredVer;
+
try {
- // TODO https://issues.apache.org/jira/browse/IGNITE-22975 Improve
minimum begin time determination
- return txCatalogVersionByBeginTxTs.keySet().stream()
- .min(HybridTimestamp::compareTo)
- .orElse(clock.now());
+ Entry<Integer, Long> entry = txCountByCatalogVersion.lastEntry();
Review Comment:
:woman_facepalming: Thanks, fixed
> The fact that all tests have passed freaks me out tbh
The problem with the test was that only single RW transaction started on
each node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
