myskov commented on code in PR #4556:
URL: https://github.com/apache/ignite-3/pull/4556#discussion_r1802418094
##########
modules/client-common/src/test/java/org/apache/ignite/internal/client/proto/ClientComputeJobPackerUnpackerTest.java:
##########
@@ -192,21 +187,6 @@ void packByteArrayUnpackStringWithMarshaller() {
}
}
- /** Pojo with unsupported type. */
- public static class UnsupportedType {
- // Unsupported type
- Object obj = new Object();
- }
-
- @Test
- void packUnsupportedType() {
Review Comment:
I removed the test because the type is no longer "unsupported." Now, any
object field will be attempted to be converted to a tuple. However, in this
case, the conversion will fail due to missing fields.
I've added a separate test, packInvalidPojoEmpty(), to cover this scenario.
Alternatively, we could make this work by creating an empty tuple when
fields are missing, though I'm not sure if that approach makes much sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
