sanpwc commented on code in PR #4552:
URL: https://github.com/apache/ignite-3/pull/4552#discussion_r1801082766


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -604,6 +604,12 @@ public boolean onBeforeApply(Command command) {
         return false;
     }
 
+    @Override
+    public void onLeaderStop() {
+        maxObservableSafeTime = -1;

Review Comment:
   That should not be a problem because before onBeforeApply we should verify 
whether we are on leader on not. Thus I don't expect onBeforeApply to be called 
after node lost it's leadership. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to