JAkutenshi commented on code in PR #4545:
URL: https://github.com/apache/ignite-3/pull/4545#discussion_r1801090861
##########
modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItLearnersTest.java:
##########
@@ -409,19 +387,17 @@ void testChangePeersToAddLearnerToSameNodeAsPeer() throws
InterruptedException {
PeersAndLearners newConfiguration = createConfiguration(followers,
List.of(learner, newLearner));
- CompletableFuture<Void> changePeersFuture =
learnerService.thenCompose(s -> s.refreshAndGetLeaderWithTerm()
- .thenCompose(leaderWithTerm ->
s.changePeersAndLearnersAsync(newConfiguration, leaderWithTerm.term())
- ));
+ CompletableFuture<Void> changePeersFuture =
learnerService.refreshAndGetLeaderWithTerm()
+ .thenCompose(leaderWithTerm ->
learnerService.changePeersAndLearnersAsync(newConfiguration,
leaderWithTerm.term()));
assertThat(changePeersFuture, willCompleteSuccessfully());
var newLearnerListener = new TestRaftGroupListener();
- CompletableFuture<RaftGroupService> newLearnerService = startRaftGroup(
+ startRaftGroup(
newLearner,
newConfiguration.learner(newLearner.consistentId()), newConfiguration,
newLearnerListener
Review Comment:
Agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
