timoninmaxim commented on code in PR #11554:
URL: https://github.com/apache/ignite/pull/11554#discussion_r1800659446
##########
modules/ducktests/tests/ignitetest/tests/thin_client_query_test.py:
##########
@@ -21,7 +21,6 @@
from ignitetest.services.ignite import IgniteService
from ignitetest.services.ignite_app import IgniteApplicationService
from ignitetest.services.utils.ignite_configuration import
IgniteConfiguration, IgniteThinClientConfiguration
-from ignitetest.services.utils.ignite_spec import IgniteNodeSpec
Review Comment:
Let's move this change to separate ticket
##########
modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py:
##########
@@ -245,13 +245,19 @@ def envs(self):
"""
:return: environment set.
"""
- return {
+ environment_dict = {
'EXCLUDE_TEST_CLASSES': 'true',
'IGNITE_LOG_DIR': self.service.log_dir,
'USER_LIBS': ":".join(self.libs()),
"MAIN_CLASS": self.service.main_java_class
}
+ if "direct-io" not in self.modules():
+ # IGNITE-23016, excluded to avoid implicit usage
Review Comment:
Remove this comment. Who need it can use git blame to understand the reason
behind this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
