sashapolo commented on code in PR #4530:
URL: https://github.com/apache/ignite-3/pull/4530#discussion_r1799442581
##########
modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageServiceTest.java:
##########
@@ -318,10 +317,8 @@ private List<Node> prepareNodes(int amount) {
}
/**
- * Starts nodes. It is important to call {@link #prepareNodes(int)}, then
configure required mocks, and only then star nodes. Otherwise
- * the {@link Node#mockStorage} (for example) will be concurrently used by
a node and configured in the test (using a
- * {@link Mockito#when(Object)}, for example). This is not allowed, mocks
must be accessed exclusively during a configuration phase,
- * it's not thread-safe.
+ * Starts nodes. It is important that this method is called before all
mocks are configured, otherwise we will have races between raft
Review Comment:
> It is important that this method is called before all mocks are configured
Are you sure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
