JAkutenshi commented on code in PR #4477:
URL: https://github.com/apache/ignite-3/pull/4477#discussion_r1796726375
##########
modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java:
##########
@@ -257,13 +259,19 @@ public void beforeTest(TestInfo testInfo) {
() ->
IgniteUtils.shutdownAndAwaitTermination(partitionOperationsExecutor, 10,
TimeUnit.SECONDS)
));
}
+
+ grpNodes = chooseRandomNodes(3);
Review Comment:
I did it because to `@AfterEach` we must to move `grpNodes` as a field.
Then, there are options: left `chooseRandomNodes` in each of actually 2 tests
(with the same argument) or move it to `@BeforeEach` that looks like more clean
(no code duplication) and idiomatic (starting before and stopping after no
mater what happened in tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
