rpuch commented on code in PR #4528:
URL: https://github.com/apache/ignite-3/pull/4528#discussion_r1793542400
##########
modules/metastorage/src/testFixtures/java/org/apache/ignite/internal/metastorage/server/SimpleInMemoryKeyValueStorage.java:
##########
@@ -970,6 +970,11 @@ public long getCompactionRevision() {
}
}
+ @Override
+ public @Nullable Long checksum(long revision) {
+ throw new UnsupportedOperationException();
Review Comment:
Checksums are not needed for normal functioning of the Metastorage, they
will only be used before starting it, when performing a special procedure to
re-enter a node that did not see the Metastorage repair. This will be tested in
integration tests, so only using the RocksDB-based storage. Hence we simply
don't need checksums in the in-mem storage. That's why it makes no sense to
implement checksums there.
If something changes in the future, we'll add this to this storage as well
(but I doubt it will change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
