sashapolo commented on code in PR #4529:
URL: https://github.com/apache/ignite-3/pull/4529#discussion_r1793342124
##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##########
@@ -241,7 +241,13 @@ public interface MetaStorageManager extends
IgniteComponent {
HybridTimestamp timestampByRevisionLocally(long revision);
/**
- * Retrieves entries for given keys.
+ * Returns a future of getting the latest version of an entries by keys
from the metastore leader.
Review Comment:
```suggestion
* Returns a future containing the latest version of entries
corresponding to the given keys from the metastore leader.
```
##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##########
@@ -241,7 +241,13 @@ public interface MetaStorageManager extends
IgniteComponent {
HybridTimestamp timestampByRevisionLocally(long revision);
/**
- * Retrieves entries for given keys.
+ * Returns a future of getting the latest version of an entries by keys
from the metastore leader.
+ *
+ * <p>Never completes with a {@link CompactedException}.</p>
+ *
+ * <p>Future may complete with {@link NodeStoppingException} if the node
is in the process of stopping.</p>
+ *
+ * @param keys Not empty keys.
Review Comment:
```suggestion
* @param keys Set of keys (must not be empty).
```
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorage.java:
##########
@@ -132,21 +131,23 @@ public interface KeyValueStorage extends
ManuallyCloseable {
List<Entry> get(byte[] key, long revLowerBound, long revUpperBound);
/**
- * Returns all entries corresponding to given keys.
+ * Returns the latest version of an entries by keys.
+ *
+ * <p>Never throws {@link CompactedException}.</p>
*
- * @param keys Keys collection.
- * @return Entries corresponding to given keys.
+ * @param keys Not empty keys.
*/
- Collection<Entry> getAll(List<byte[]> keys);
+ List<Entry> getAll(List<byte[]> keys);
/**
- * Returns all entries corresponding to given keys and bounded by the
given revision.
+ * Returns an entries by the given keys and bounded by the given revision.
Review Comment:
```suggestion
* Returns entries corresponding to the given keys and bounded by the
given revision.
```
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorage.java:
##########
@@ -132,21 +131,23 @@ public interface KeyValueStorage extends
ManuallyCloseable {
List<Entry> get(byte[] key, long revLowerBound, long revUpperBound);
/**
- * Returns all entries corresponding to given keys.
+ * Returns the latest version of an entries by keys.
+ *
+ * <p>Never throws {@link CompactedException}.</p>
*
- * @param keys Keys collection.
- * @return Entries corresponding to given keys.
+ * @param keys Not empty keys.
*/
- Collection<Entry> getAll(List<byte[]> keys);
+ List<Entry> getAll(List<byte[]> keys);
/**
- * Returns all entries corresponding to given keys and bounded by the
given revision.
+ * Returns an entries by the given keys and bounded by the given revision.
*
- * @param keys Keys collection.
+ * @param keys Not empty keys.
* @param revUpperBound Upper bound of revision.
- * @return Entries corresponding to given keys.
+ * @throws CompactedException If getting one of an entries will throw this
exception as if using {@link #get(byte[], long)}.
Review Comment:
```suggestion
* @throws CompactedException If getting any of the individual entries
would have thrown this exception as if {@link #get(byte[], long)} was used.
```
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorage.java:
##########
@@ -60,8 +60,7 @@ public interface KeyValueStorage extends ManuallyCloseable {
*
* <p>Never throws {@link CompactedException}.</p>
*
- * @param key The key.
- * @return Value corresponding to the given key.
Review Comment:
What is this change for?
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorage.java:
##########
@@ -132,21 +131,23 @@ public interface KeyValueStorage extends
ManuallyCloseable {
List<Entry> get(byte[] key, long revLowerBound, long revUpperBound);
/**
- * Returns all entries corresponding to given keys.
+ * Returns the latest version of an entries by keys.
Review Comment:
```suggestion
* Returns the latest version of entries corresponding to the given keys
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
