rpuch commented on code in PR #4433:
URL: https://github.com/apache/ignite-3/pull/4433#discussion_r1793292323
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java:
##########
@@ -332,60 +337,98 @@ private void listenForRecovery(long targetRevision) {
}
}
- private CompletableFuture<MetaStorageServiceImpl>
initializeMetaStorage(Set<String> metaStorageNodes) {
+ private CompletableFuture<MetaStorageServiceImpl>
initializeMetaStorage(MetaStorageInfo metaStorageInfo) {
try {
- String thisNodeName = clusterService.nodeName();
-
- var disruptorConfig = new
RaftNodeDisruptorConfiguration("metastorage", 1);
-
- CompletableFuture<? extends RaftGroupService>
localRaftServiceFuture = metaStorageNodes.contains(thisNodeName)
- ? startFollowerNode(metaStorageNodes, disruptorConfig)
- : startLearnerNode(metaStorageNodes, disruptorConfig);
-
- raftNodeStarted.complete(null);
+ if (thisNodeDidNotWitnessMetaStorageRepair(metaStorageInfo)) {
Review Comment:
I filed an issue to address this race
https://issues.apache.org/jira/browse/IGNITE-23391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
