tkalkirill commented on code in PR #4465:
URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778475814
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -1026,104 +1027,41 @@ private boolean addToBatchForRemoval(WriteBatch batch,
byte[] key, long curRev,
}
/**
- * Compacts all entries by the given key, removing revision that are no
longer needed.
- * Last entry with a revision lesser or equal to the {@code
minRevisionToKeep} and all consecutive entries will be preserved.
- * If the first entry to keep is a tombstone, it will be removed.
- * Example:
- * <pre>
- * Example 1:
- * put entry1: revision 5
- * put entry2: revision 7
- *
- * do compaction: revision 6
- *
- * entry1: exists
- * entry2: exists
- *
- * Example 2:
- * put entry1: revision 5
- * put entry2: revision 7
- *
- * do compaction: revision 7
- *
- * entry1: doesn't exist
- * entry2: exists
- * </pre>
+ * Compacts the key, see the documentation of {@link
KeyValueStorage#compact} for examples.
*
* @param batch Write batch.
- * @param key Target key.
- * @param revs Revisions.
- * @param minRevisionToKeep Minimum revision that should be kept.
- * @throws RocksDBException If failed.
+ * @param key Target key.
+ * @param revs Key revisions.
+ * @param compactionRevision Revision up to which the key will be
compacted.
Review Comment:
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
