Vladsz83 commented on code in PR #11539:
URL: https://github.com/apache/ignite/pull/11539#discussion_r1773923737


##########
modules/core/src/test/java/org/apache/ignite/internal/processors/service/IgniteServiceDeploymentClassLoadingDefaultMarshallerTest.java:
##########
@@ -152,6 +163,30 @@ public void testServiceDeployment3() throws Exception {
         
startClientGrid(CLIENT_NODE_WITH_EXT_CLASS_LOADER).services().deploy(serviceConfig());
     }
 
+    /** @throws Exception If failed. */
+    @Test
+    public void testFailWhenNodeFilterClassNotFound() throws Exception {

Review Comment:
   Suggestion: a test for re-deploy. Or several. Scenarios: redeploy with empty 
node filter, redeploy with a known class filter, redeploy with another unknows 
class ode filter. WDYT? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to