zstan commented on code in PR #4422:
URL: https://github.com/apache/ignite-3/pull/4422#discussion_r1773695775
##########
modules/platforms/dotnet/Apache.Ignite.Tests/Sql/SqlTests.cs:
##########
@@ -519,7 +519,7 @@ public async Task TestCustomDecimalScale()
await using var resultSet = await Client.Sql.ExecuteAsync(null,
"select cast((10 / ?) as decimal(20, 5))", 3m);
IIgniteTuple res = await resultSet.SingleAsync();
- Assert.AreEqual(3.33333m, res[0]);
+ Assert.AreEqual(3.00000m, res[0]);
Review Comment:
Yes, i can, previously we call SqlFunctions#divide() and it implementation
is a bit diff from current:
calcite : b0.divide(b1, MathContext.DECIMAL64)
current: x.divide(y, RoundingMode.HALF_DOWN)
i can change it like calcite but test "test_correlated_any_all.test" will
fail in such a case and as for me this is not hack from my side, check: we
create accumulator MinMaxAccumulator with RelDataType as a parameter, but also
if scale of such a type is == 0 input data still can has some fractional data
which brings errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
