ygerzhedovich commented on code in PR #4409:
URL: https://github.com/apache/ignite-3/pull/4409#discussion_r1771512639
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/tests/BaseDmlDataTypeTest.java:
##########
@@ -89,19 +87,6 @@ public void testUpdateFromDynamicParam() {
.check();
}
- /**
- * Type mismatch in {@code INSERT}s {@code VALUES} with dynamic parameters.
- */
- @ParameterizedTest
- @MethodSource("convertedFrom")
- public void
testDisallowMismatchTypesOnInsertDynamicParam2(TestTypeArguments<T> arguments) {
Review Comment:
Why did you decide to remove the test?
##########
modules/jdbc/src/integrationTest/java/org/apache/ignite/jdbc/ItJdbcComplexQuerySelfTest.java:
##########
@@ -210,7 +210,7 @@ public void testWrongArgumentType() throws Exception {
// Check non-indexed field.
JdbcTestUtils.assertThrowsSqlException(
"Invalid input string for type INTEGER: \"B\"",
- () -> stmt.executeQuery("select * from PUBLIC.Org where name =
2"));
+ () -> stmt.executeQuery("select * from PUBLIC.Org where
name::INTEGER = 2"));
Review Comment:
I didn't catch this, why we need to cast `name` to an integer to get an
error? If we forbidden implicit casts it should fail without any change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
