alex-plekhanov commented on code in PR #11525:
URL: https://github.com/apache/ignite/pull/11525#discussion_r1771488039
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/ExpressionFactoryImpl.java:
##########
@@ -237,7 +239,8 @@ else if (c2 != HIGHEST_VALUE)
}
// If compared rows contain NULLs, they shouldn't be treated
as equals, since NULL <> NULL in SQL.
- return hasNulls ? 1 : 0;
+ // Expect for cases with IS DISTINCT / IS NOT DISTINCT.
+ return hasNulls ? nullComparison : 0;
Review Comment:
But you always return nullComparison for field 0, while nulls can be on
another field. So it's not better than just return 1, which means that it's not
equals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
