alex-plekhanov commented on code in PR #11493:
URL: https://github.com/apache/ignite/pull/11493#discussion_r1768394787
##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientCache.java:
##########
@@ -80,13 +80,13 @@
*/
public class TcpClientCache<K, V> implements ClientCache<K, V> {
/** "Keep binary" flag mask. */
- private static final byte KEEP_BINARY_FLAG_MASK = 0x01;
+ public static final byte KEEP_BINARY_FLAG_MASK = 0x01;
Review Comment:
package private
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/tx/SqlTransactionsIsolationTest.java:
##########
@@ -1114,8 +1141,10 @@ public List<List<?>> sql(String sqlText, int[] parts,
Object... args) {
if (!F.isEmpty(parts))
qry.setPartitions(parts);
- if (type == ExecutorType.THIN)
- return thinCli.query(qry).getAll();
+ if (type == ExecutorType.THIN_VIA_CACHE_API)
+ return unwrapBinary(thinCli.query(qry).getAll());
+ else if (type == ExecutorType.THIN_VIA_QUERY)
+ return
unwrapBinary(thinCli.cache(F.first(thinCli.cacheNames())).query(qry).getAll());
if (multi) {
Review Comment:
Rednundant braces
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/tx/SqlTransactionsIsolationTest.java:
##########
@@ -101,7 +103,10 @@ public enum ExecutorType {
CLIENT,
/** */
- THIN
+ THIN_VIA_CACHE_API,
Review Comment:
Why thin client is created via private API TcpIgniteClient and not by
Ignition.startClient?
##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientCache.java:
##########
@@ -80,13 +80,13 @@
*/
public class TcpClientCache<K, V> implements ClientCache<K, V> {
/** "Keep binary" flag mask. */
- private static final byte KEEP_BINARY_FLAG_MASK = 0x01;
+ public static final byte KEEP_BINARY_FLAG_MASK = 0x01;
/** "Transactional" flag mask. */
- private static final byte TRANSACTIONAL_FLAG_MASK = 0x02;
+ public static final byte TRANSACTIONAL_FLAG_MASK = 0x02;
Review Comment:
package private
##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientCache.java:
##########
@@ -80,13 +80,13 @@
*/
public class TcpClientCache<K, V> implements ClientCache<K, V> {
/** "Keep binary" flag mask. */
- private static final byte KEEP_BINARY_FLAG_MASK = 0x01;
+ public static final byte KEEP_BINARY_FLAG_MASK = 0x01;
/** "Transactional" flag mask. */
- private static final byte TRANSACTIONAL_FLAG_MASK = 0x02;
+ public static final byte TRANSACTIONAL_FLAG_MASK = 0x02;
/** "With expiry policy" flag mask. */
- private static final byte WITH_EXPIRY_POLICY_FLAG_MASK = 0x04;
+ public static final byte WITH_EXPIRY_POLICY_FLAG_MASK = 0x04;
Review Comment:
private (no usages outside this class)
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/tx/SqlTransactionsIsolationTest.java:
##########
@@ -1114,8 +1141,10 @@ public List<List<?>> sql(String sqlText, int[] parts,
Object... args) {
if (!F.isEmpty(parts))
qry.setPartitions(parts);
- if (type == ExecutorType.THIN)
- return thinCli.query(qry).getAll();
+ if (type == ExecutorType.THIN_VIA_CACHE_API)
+ return unwrapBinary(thinCli.query(qry).getAll());
+ else if (type == ExecutorType.THIN_VIA_QUERY)
+ return
unwrapBinary(thinCli.cache(F.first(thinCli.cacheNames())).query(qry).getAll());
Review Comment:
CacheAPI and query are confused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
