sanpwc commented on code in PR #4425:
URL: https://github.com/apache/ignite-3/pull/4425#discussion_r1766787596


##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -609,17 +608,14 @@ private CompletableFuture<HybridTimestamp> 
stopLeaseProlongation(
                         .thenCompose(unused -> {
                             NetworkMessage response = futs.stream()
                                     .map(CompletableFuture::join)
-                                    .filter(Objects::nonNull)
+                                    .filter(resp -> resp instanceof 
StopLeaseProlongationMessageResponse
+                                            && 
((StopLeaseProlongationMessageResponse) resp).deniedLeaseExpirationTime() != 
null)

Review Comment:
   How do we use deniedLeaseExpirationTime()? I mean other cases besides 
checking whether it's null or not?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to