NSAmelchev commented on code in PR #286:
URL: https://github.com/apache/ignite-extensions/pull/286#discussion_r1766283310


##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteCdcStreamerConfiguration.java:
##########
@@ -175,6 +184,34 @@ public void setCaches(Collection<String> caches) {
         this.caches = caches;
     }
 
+    /**
+     * @return Include regex templates
+     */
+    public Set<String> getIncludeTemplates() {
+        return includeTemplates;
+    }
+
+    /**
+     * @param includeTemplates Include regex templates
+     */
+    public void setIncludeTemplates(Set<String> includeTemplates) {

Review Comment:
   Do we need a set of patterns and exclude patterns? Seems other products 
provide only single pattern, for example [Kafka 
consumer](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L753).
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to