Vladsz83 commented on code in PR #11478:
URL: https://github.com/apache/ignite/pull/11478#discussion_r1725342368
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/RexImpTable.java:
##########
@@ -1093,12 +1087,11 @@ else if (exprVal == SqlJsonEmptyOrError.ERROR) {
newOperands.add(dfltValOnEmpty);
newOperands.add(errorBehavior);
newOperands.add(dfltValOnError);
- Class clazz = method.getDeclaringClass();
- expression = EnumUtils.call(null, clazz, method.getName(),
newOperands);
-
- final Type returnType =
- translator.typeFactory.getJavaClass(call.getType());
- return EnumUtils.convert(expression, returnType);
+ List<Expression> argValList0 =
Review Comment:
I think we should not skip Ignite's codestyle when taking side code. Line
breaks between different operations, single lines, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
