rpuch commented on code in PR #2473:
URL: https://github.com/apache/ignite-3/pull/2473#discussion_r1311758411
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/incoming/IncomingSnapshotCopier.java:
##########
@@ -142,7 +176,7 @@ public void join() throws InterruptedException {
LOG.error("Error when completing the copier", cause);
- if (!isOk()) {
+ if (isOk()) {
Review Comment:
This is how it works in `LocalSnapshotCopier`. Otherwise, if no error gets
registered from elsewhere, we will never register any error; but, if some error
already happened somewhere, we will overwrite it. It seems better to only leave
the first error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
