sashapolo commented on code in PR #2487:
URL: https://github.com/apache/ignite-3/pull/2487#discussion_r1303265289
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/instance/SharedRocksDbInstanceCreator.java:
##########
@@ -197,10 +199,10 @@ private ColumnFamilyOptions createCfOptions(byte[]
cfName, Path path) {
return add(new ColumnFamilyOptions());
case PARTITION:
- return add(new
ColumnFamilyOptions().useFixedLengthPrefixExtractor(PartitionDataHelper.ROW_PREFIX_SIZE));
+ return
add(defaultCfOptions().useCappedPrefixExtractor(PartitionDataHelper.ROW_PREFIX_SIZE));
Review Comment:
If I understood the C++ code correctly, FixedLengthExtractor does not enable
prefix seek if a given prefix's length is less than configured (e.g. when we do
seek on a table ID + partion ID) only. I can't say that it makes a difference,
though (at least I haven't noticed it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]