xtern commented on code in PR #2449:
URL: https://github.com/apache/ignite-3/pull/2449#discussion_r1303093350
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -518,6 +505,25 @@ public CompletableFuture<Void> closeAsync() {
return stage;
}
+ private static QueryTransactionWrapper beginImplicitTxIfNeeded(
Review Comment:
:weary: But as far as I remember, we decided that this is wrong from an
architectural point of view.
We decided that wrapper should not do any unclear things :roll_eyes: .
For example what is the return type of the following call?
wrapper.beginImplicitTxIfNeeded(..
`void` or `InternalTransaction` or... 'QueryTransactionWrapper`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
