AMashenkov commented on code in PR #2485:
URL: https://github.com/apache/ignite-3/pull/2485#discussion_r1302918572
##########
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java:
##########
@@ -1040,39 +1040,11 @@ public void testCreateSortedIndex() {
assertEquals("VAL", index.columns().get(0).name());
assertEquals("ID", index.columns().get(1).name());
assertEquals(CatalogColumnCollation.DESC_NULLS_FIRST,
index.columns().get(0).collation());
- assertEquals(CatalogColumnCollation.ASC_NULLS_LAST,
index.columns().get(1).collation());
+ assertEquals(ASC_NULLS_LAST, index.columns().get(1).collation());
assertTrue(index.unique());
assertFalse(index.writeOnly());
}
- @Test
- public void testCreateIndexWithSameName() {
- assertThat(manager.createTable(simpleTable(TABLE_NAME)),
willBe(nullValue()));
-
- CreateHashIndexParams params = CreateHashIndexParams.builder()
- .indexName(INDEX_NAME)
- .tableName(TABLE_NAME)
- .columns(List.of("VAL"))
- .build();
-
- assertThat(manager.createIndex(params), willBe(nullValue()));
- assertThat(manager.createIndex(params),
willThrow(IndexAlreadyExistsException.class));
- }
-
- @Test
- public void testCreateIndexOnDuplicateColumns() {
Review Comment:
Why do you drop this test?
Duplicate columns issue looks like a typo. E.g. in "VAL1, VAL2, VAL1" we
can't be sure if user means:
"VAL1, VAL2" or "VAL2, VAL1" or "VAL1, VAL2, VAL3" or whatever else.
In general, this case is invalid, and we would like to have a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
