AMashenkov commented on code in PR #2485:
URL: https://github.com/apache/ignite-3/pull/2485#discussion_r1302881882
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##########
@@ -965,7 +936,25 @@ public void listen(CatalogEvent evt, EventListener<?
extends CatalogEventParamet
listen(evt, (EventListener<CatalogEventParameters>) closure);
}
- private static @Nullable CatalogDataStorageDescriptor
dataStorage(@Nullable DataStorageParams params) {
- return params == null ? null : fromParams(params);
+ private static void checkNotExistsIndexOrTable(CatalogSchemaDescriptor
schema, String indexName) {
+ if (schema.index(indexName) != null) {
+ throw new IndexAlreadyExistsException(schema.name(), indexName);
+ }
+
+ if (schema.table(indexName) != null) {
+ throw new TableAlreadyExistsException(schema.name(), indexName);
+ }
+ }
+
+ private static void checkIndexColumns(CatalogTableDescriptor table,
AbstractCreateIndexCommandParams params) {
Review Comment:
```suggestion
private static void validateIndexColumns(CatalogTableDescriptor table,
AbstractCreateIndexCommandParams params) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
