sanpwc commented on code in PR #2475:
URL: https://github.com/apache/ignite-3/pull/2475#discussion_r1302802472
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -1025,15 +1044,26 @@ private CompletableFuture<Void> continueIndexLookup(
return lockManager.acquire(txId, new LockKey(tableId(), rowId),
LockMode.S)
.thenComposeAsync(rowLock -> { // Table row S lock
ReadResult readResult = mvDataStorage.read(rowId,
HybridTimestamp.MAX_VALUE);
- return resolveAndCheckReadCompatibility(readResult, txId)
- .thenCompose(resolvedReadResult -> {
- if (resolvedReadResult != null) {
- result.add(resolvedReadResult);
- }
+ return resolveAndCheckReadCompatibility(readResult, txId,
() -> {
+ if (readResult.newestCommitTimestamp() == null) {
Review Comment:
Anyway it seems strange to have such duplications. If there are two
different triggers, let's add two different resolve helpers one for cursor and
one for storage, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
