sanpwc commented on code in PR #2183:
URL: https://github.com/apache/ignite-3/pull/2183#discussion_r1230582451
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java:
##########
@@ -277,14 +278,16 @@ public void unregisterWatch(WatchListener lsnr) {
}
@Override
- public void deployWatches() throws NodeStoppingException {
+ public CompletableFuture<Void> deployWatches() {
if (!busyLock.enterBusy()) {
- throw new NodeStoppingException();
+ return CompletableFuture.failedFuture(new NodeStoppingException());
Review Comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
