[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #2115: IGNITE-19478 Possible excess size of table entities written into meta storage

[via GitHub]

denis-chudov commented on code in PR #2115:
URL: https://github.com/apache/ignite-3/pull/2115#discussion_r1211321154


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -2004,7 +2005,7 @@ private CompletableFuture<Void> 
handleChangePendingAssignmentEvent(
 
         Set<Assignment> stableAssignments = stableAssignmentsBytes == null
                 // This is for the case when the first rebalance occurs.
-                ? ((List<Set<Assignment>>) 
ByteUtils.fromBytes(tblCfg.assignments().value())).get(partId)
+                ? 
Assignments.fromBytes(tblCfg.assignments().value()).get(partId)
                 : ByteUtils.fromBytes(stableAssignmentsBytes);

Review Comment:
   `stableAssignmentsBytes` is taken from different meta storage entries, 
managed by rebalance. If it is `null`, assignments for partition are taken from 
table configuration. Serialization was reworked only for table configuration, 
not for rebalance keys.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org