butterfly-520-boy commented on issue #1677: URL: https://github.com/apache/hertzbeat/issues/1677#issuecomment-5956596133
Hi, I would like to work on this issue. I confirmed that the problem is still present on the latest `upstream/master`. `CommonHttpClient` creates its default `RequestConfig` without specifying a cookie policy, so Apache HttpClient 4.5 uses its default policy and rejects RFC 1123 `expires` values such as `Wed, 22 Mar 2034 06:03:16 GMT`. I could not find an open PR covering this issue. My proposed scope is: 1. Configure the shared HTTP client with `CookieSpecs.STANDARD`. 2. Add a regression test using a local HTTP server that returns a `Set-Cookie` header with an RFC 1123 expiration date. 3. Verify that the cookie is parsed into the request context's `CookieStore`. 4. Run the `hertzbeat-collector-common` test suite and relevant style checks. This should not change the public API; it only makes cookie parsing standards-compliant and prevents repeated `Invalid cookie header` warnings. Please let me know if anyone is already working on it. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
