SatyamPandey-07 commented on PR #4371: URL: https://github.com/apache/hertzbeat/pull/4371#issuecomment-5917166249
Hi @zqr10159, thanks for the thorough review! I have updated both the English and Chinese documentation pages: 1. **Pattern parameter**: Omitted `Pattern` from the user-facing configuration table in both docs since it is an internal mode parameter defined as `hide: true` with a default of `2`. 2. **SSH Timeout**: Aligned `SSH Timeout(ms)` default to `6000ms` (and `6000 毫秒` in Chinese) to match `sshTimeout` in `app-redis_sentinel.yml`. ### Local Validation - **Filename check**: `python ./script/ci/docs/check_file_name.py ./script/ci/docs/check_file_name.json` → Passed. - **Markdown lint**: `pnpm run md-lint` → Passed (571 files checked, 0 errors). - **Site build**: Ran `pnpm run build` locally → Built successfully for all locales (`en`, `zh-cn`, `ko`) with no broken links or markdown link errors. - **Help routes**: Verified `/docs/help/redis_sentinel` and `/docs/help/kvrocks` routes match the `helpLink` values in `app-redis_sentinel.yml` and `app-kvrocks.yml`. Please take another look when you have a moment. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
