utafrali commented on code in PR #4389: URL: https://github.com/apache/hertzbeat/pull/4389#discussion_r4058080630
########## hertzbeat-manager/src/main/resources/define/app-s7.yml: ########## @@ -28,6 +28,9 @@ help: en-US: HertzBeat collects metrics related to maintaining registers and coils for services that support s7 protocol zh-TW: HertzBeat對支持s7協定的服務進行（保持寄存器和線圈）相關名額進行採集 ja-JP: HertzBeatはs7プロトコルをサポートするサービスのメトリクスを監視します。 +helpLink: Review Comment: The S7 help documentation doesn't exist yet (acknowledged in the PR description), so both URLs here will return 404 until the follow-up PR lands. A dead link is a worse user experience than no link at all. Consider one of these approaches: 1. Drop the `helpLink` block from this file now and add it in the same PR that ships the S7 docs. 2. Or, if the docs page already exists in draft/stub form, verify the URLs resolve before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
