Duansg commented on PR #4368: URL: https://github.com/apache/hertzbeat/pull/4368#issuecomment-5567498577
@zqr10159 Thanks — agreed on the numbering, and done. Confirmed the boundary first: tag `1.8.0` (1b51c19c97) ends at `V180`, so V181 (#4016), V182 (#4280) and V183 (#4330) are all 1.9.0 content. They're now one `V190__update_column.sql` per dialect: create table → disable ownerless schedules → enlarge `expr`, keeping the portable `FALSE` and leaving `idx_schedule_creator_conversation` to `@Index`. Two things worth flagging from the merge: - **`enabled` is now `BOOLEAN` in all three dialects.** `FlywayConfiguration` delays Flyway until after Hibernate `ddl-auto`, so the table is always created by Hibernate and the migration's `CREATE TABLE` never runs — that's the root cause of the `42804`. Under the conventional Flyway-first ordering, PostgreSQL would create `SMALLINT` and `SET enabled = FALSE` would fail with the mirror-image error. `BOOLEAN` makes the script correct either way and matches `SopSchedule.enabled`. - **MySQL's `DELIMITER` block is kept last**, preceded by `DROP PROCEDURE IF EXISTS`, so the routine body can't swallow the statements above it and a re-run stays clean. Verified with `flyway-core` 10.11.1 (Flyway's own parser, not a SQL client) on H2 2.2.224, MySQL 8.4 and PostgreSQL 17, both execution orders, twice per run — all pass and are idempotent. The same harness on the old scripts reproduces `42804` and `1061`. Details in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
