Duansg opened a new pull request, #4367:
URL: https://github.com/apache/hertzbeat/pull/4367

   ## What's changed?
   
   #4257 and #4271 added the `/api/plugin/**` and `/api/account/token*` admin 
rules to `hertzbeat-startup/src/main/resources/sureness.yml`, but the six 
copies we actually ship were never updated:
   
   - `script/sureness.yml` — the file `docs/start/docker-deploy.md` tells 
`docker run` users to download and mount over the one in the image.
   - `conf/sureness.yml` in all five Docker Compose variants — compose mounts 
it as `./conf/sureness.yml:/opt/hertzbeat/config/sureness.yml`, overriding the 
image copy.
   
   Sureness lets a path with no matching rule through for any authenticated 
role, so on both of those deployments **guest can still upload plugins and 
issue or revoke API tokens** — the two fixes above never took effect on the 
released artifacts. Four of the compose copies were also missing the 
`/observability/**`, `/metrics/**` and `/trace/**` static-resource exclusions.
   
   This PR aligns all six copies with 
`hertzbeat-startup/src/main/resources/sureness.yml`; they now `diff` clean 
against it. Those omissions were the only differences — the `sureness.auths` 
account section is unchanged.
   
   ## Checklist
   
   - [x]  I have read the [Contributing 
Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide)
   - [x]  I have written the necessary doc or comment.
   - [ ]  I have added the necessary unit tests and all cases have passed.
   
   ## Add or update API
   
   - [ ] I have added the necessary [e2e 
tests](https://github.com/apache/hertzbeat/tree/master/e2e) and all cases have 
passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to